Better position for error and notice message#71
Open
mafigit wants to merge 1 commit intokmerz:masterfrom
Open
Conversation
- since we included the error and notice message in the container of the page you were not able to see some of the error/notice messages, if you scrolled down too far.
Owner
|
When I login the error message is not in focus of the screen. It appears on the top to the right. So I don't really see it. This is not good :( But we would have to deal with this differently anyway. Can you tell me where I can take a look where this change improves the error messages. Don't get me wrong, we don't deal with errors good anyway and we should change that :) So I look forward for any improvement. I just can't see right now :) |
Contributor
Author
|
for example when you like a post, but you are not logged in. you can not see the error message at all, if you scroll down too far. |
Owner
Contributor
Author
|
Sorry didnt test it in such low resolution devices ;) but yes we should make it a bit different |
Owner
|
Uhh.. so you never shrink your window 🎱 :) |
Contributor
Author
|
I am working on it :) |
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

page you were not able to see some of the error/notice messages, if
you scrolled down too far.